[
https://issues.apache.org/jira/browse/SOLR-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846219#action_12846219
]
Mark Miller commented on SOLR-1817:
-----------------------------------
bq. two of the places you removed "adds" to SolrConfig.severErrors are in
IndexSchema,
Yeah, actually locally I had put those back for now - I didnt really mean to
leave that in the patch - I originally started by removing
SolrConfig.severErrors and trying to work stop using it, and I just removed
those - but easy to lose track of fixing those points so I had put them back.
bq. why is "admin" suddenly a magic alias for "" in SolrDispatchFilter? (line
196)
I had to do that to get /solr from displaying exceptions when the default core
couldn't load I think - that and another change.
That is all kind of weird right now anyway - when the dispatchFilter sees
/solr/admin, it actually looks for a core named admin - and just doesn't
(hopefully) find it, so that it can continue and actually load the admin page.
But anyway, at the bottom of that method, if /solr/admin could not be loaded, I
actually need to look for severe errors from the "" core - not the admin core.
So right now it's simply a workaround for that case. It would normally fall
into that if statement anyway - because trying to get the 'admin' core would
return null. But in this case, I only want it to fall in if it sees admin -
otherwise - ugg, I can't remember, but something doesn't work right - I'd have
to get back into it - I spent a bunch of time using the debugger and trying all
the different paths to figure out how to get each case to work. I setup a
default core and another core and took turns breaking one or the other.
bq. the big comment about servlet container behavior...
Indeed, that needs to go.
> Fix Solr error reporting to work correctly with multicore
> ---------------------------------------------------------
>
> Key: SOLR-1817
> URL: https://issues.apache.org/jira/browse/SOLR-1817
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.5
>
> Attachments: SOLR-1817.patch, SOLR-1817.patch, SOLR-1817.patch
>
>
> Here is a rough patch that attempts to fix how error reporting works with
> multi-core (not in terms of logs, but what you see on an http request).
> The patch is not done - more to consider and havn't worked with how this
> changes solrconfigs abortOnConfigurationError, but the basics are here.
> If you attempt to access the path of a core that could not load, you are
> shown the errors that kept the core from properly loading.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
