Looks good for me. regards Alex
On 21.07.2015 18:17, Sergey Bylokhov wrote:
Hello. Please review the fix for jdk9. Two issues were fixed: 8013586: audioInputStream.close() does not release the resource 8130305: AudioSystem behavior depends on order that providers are located Description: - Streams were not closed when necessary(ex: WaveFloatFileReader. getAudioInputStream(File)). In the fix they are closed always in case of any exceptions. - Some of the readers do not reset the streams when they throw an UnsupportedAudioFileException exception. - Some of the readers(like AiffFileReader) do not wrap (FileInputStream, etc) in BufferedInputStream. In the fix I merge all implementations of getAudioXXX to the SunFileReader. Note that I added a comment to the SunFileReader.getAudioFileFormat(InputStream) that implementation contradicts the specification, and it seems the javadoc should be updated? And I created a new issue about EOFException: https://bugs.openjdk.java.net/browse/JDK-8131974 Also I have a related question about WaveExtensibleFileReader why it was not added to the spi.AudioFileReader? Because of this WaveExtensibleFileReader actually is never used. Is that intentionally? Bug: https://bugs.openjdk.java.net/browse/JDK-8013586 Webrev can be found at: http://cr.openjdk.java.net/~serb/8013586/webrev.02 -- Best regards, Sergey.
