On 16/12/15 18:03, Dan Rollo wrote:
Could you add unit tests for the surviving AU format?
We already have a tests in the closed repo, and some tests from our sqe team, which cover different supported audio files. Since the adding of binary files to our ws is not easy, I plan to do this at once in one separate fix for:
JDK-8044817: Migrate Sound functional tests https://bugs.openjdk.java.net/browse/JDK-8044817
On Dec 16, 2015, at 8:16 AM, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: Hello, Audio Guru. Please review the fix for jdk9. Long long time ago support of AU format was implemented with assumption to support a few standards: - ".snd"(official SUN standard) - "\0ds." (extension DEC) Also we support both big/little-endian. But later we removed support of little-endian from the writer in the https://bugs.openjdk.java.net/browse/JDK-4297100 And now after a manual code review I found that we actually never supported little-endian/DEC, because of the typo in AuFileReader.java As a fix I suggest to drop support of non standard extensions, and work only in case of ".snd" + big-endian. Description of AU standard: https://en.wikipedia.org/wiki/Au_file_format Bug: https://bugs.openjdk.java.net/browse/JDK-8135088 Webrev can be found at: http://cr.openjdk.java.net/~serb/8135088/webrev.00 -- Best regards, Sergey.
-- Best regards, Sergey.
