+1 .. the change was a bit more than I was expecting for bug described
as a typo ;-)
-phil.
On 12/18/2015 04:05 PM, Sergey Bylokhov wrote:
Thanks Alex.
Any volunteers for a second reviewer?
FYI
- I just found that our audio_writers still incorrectly handle the
"new" PCM_FLOAT format which was added in jdk7. I will fix it in my
next review request.
- Also I found that "AudioFileFormat.Type.SND" is not used, probably
someone know why?
On 16/12/15 21:26, Alex Menkov wrote:
The fix looks good.
--alex
On 16.12.2015 16:16, Sergey Bylokhov wrote:
Hello, Audio Guru.
Please review the fix for jdk9.
Long long time ago support of AU format was implemented with assumption
to support a few standards:
- ".snd"(official SUN standard)
- "\0ds." (extension DEC)
Also we support both big/little-endian.
But later we removed support of little-endian from the writer in the
https://bugs.openjdk.java.net/browse/JDK-4297100
And now after a manual code review I found that we actually never
supported little-endian/DEC, because of the typo in AuFileReader.java
As a fix I suggest to drop support of non standard extensions, and work
only in case of ".snd" + big-endian.
Description of AU standard:
https://en.wikipedia.org/wiki/Au_file_format
Bug: https://bugs.openjdk.java.net/browse/JDK-8135088
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8135088/webrev.00
