In article <20090411210833.go22...@hairylemon.org>, Andrew Doran <a...@netbsd.org> wrote: >On Sat, Apr 11, 2009 at 11:47:34AM -0400, Christos Zoulas wrote: > >> Module Name: src >> Committed By: christos >> Date: Sat Apr 11 15:47:34 UTC 2009 >> >> Modified Files: >> src/sys/dev/dmover: dmover_io.c >> src/sys/dev/putter: putter.c >> src/sys/kern: kern_drvctl.c sys_mqueue.c >> src/sys/net: bpf.c bpfdesc.h if_tap.c >> src/sys/opencrypto: cryptodev.c >> src/sys/sys: mqueue.h >> >> Log Message: >> Fix PR/37878 and PR/37550: Provide stat(2) for all devices and don't use >> fbadop_stat. > >The locking is all screwed up or missing. stat() can be expected to report >bad times for these files. I wrote the below to you in private and forgot to >copy the list. >
I added locking as you suggested, and if it is screwed up or missing it is screwed up the same way in all the existing copies of fop_stat() which were there before I added mine. As for invalid timestamps, all set proper timestamps except drvctl and you did not mention that. There is prior art of not setting timestamps as I mentioned in my original message in the socket code for non-unix sockets. It is much easier and saves time to explain what the mistakes are rather than sending out messages saying this is wrong or that is wrong. christos
