hi,

> On Wed Apr 15 2009 at 11:41:26 +0000, YAMAMOTO Takashi wrote:
>> Module Name: src
>> Committed By:        yamt
>> Date:                Wed Apr 15 11:41:26 UTC 2009
>> 
>> Modified Files:
>>      src/sys/fs/tmpfs: tmpfs_vnops.c
>> 
>> Log Message:
>> plug some pnbuf leaks.
> 
> Shouldn't that, theoretically, check for SAVESTART?

sure.

> (I don't think
> there are any users in the tree, though, and I would prefer to see it
> consistently go away from all post-lookup vnops).

let's wait for dholland cleaning it up. :)

YAMAMOTO Takashi

> 
>> @@ -679,6 +679,7 @@
>>              vrele(dvp);
>>      else
>>              vput(dvp);
>> +    PNBUF_PUT(cnp->cn_pnbuf);
>>  
>>      return error;
>>  }
>> @@ -1061,6 +1062,7 @@
>>      /* Release the nodes. */
>>      vput(dvp);
>>      vput(vp);
>> +    PNBUF_PUT(cnp->cn_pnbuf);
>>  
>>      return error;
>>  }
>> 

Reply via email to