On 01.04.2020 15:47, Robert Elz wrote:
> Date: Wed, 1 Apr 2020 11:45:53 +0000
> From: "Kamil Rytarowski" <ka...@netbsd.org>
> Message-ID: <20200401114554.05167f...@cvs.netbsd.org>
>
> | Log Message:
> | Avoid comparison between signed and unsigned integer
> |
> | Cast PAGE_SIZE to size_t.
>
> This kind of pedantry is going way too far, PAGE_SIZE is a compile
> time constant (1 << PAGE_SHIFT) which is an int (and so signed,
> nominally) but one which is known to be positive.
>
I got reports that certain ports no longer build due to:
src/sys/modules/examples/fopsmapper/fopsmapper.c:118:11: error:
comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
if (size != PAGE_SIZE)
^~
cc1: all warnings being treated as errors
