On 22-01-16 12:11, rudolf wrote:
| On 1/9/22 4:33 AM, Luke Mewburn wrote:
| > Module Name: src
| > Committed By: lukem
| > Date: Sun Jan 9 03:33:26 UTC 2022
| >
| > Modified Files:
| > src/usr.sbin/etcupdate: etcupdate etcupdate.8
| >
| > Log Message:
| > etcupdate: add -? for help. improve option errors
| >
| > Support -? to show help.
| > Implemented using getopts "leading colon optstring" feature.
| > Improve error messages for unknown options and missing arguments.
| > Change usage-related errors from stdout to stderr.
| > Keep all other errors to stdout for now.
| >
| >
| > To generate a diff of this commit:
| > cvs rdiff -u -r1.63 -r1.64 src/usr.sbin/etcupdate/etcupdate
| > cvs rdiff -u -r1.24 -r1.25 src/usr.sbin/etcupdate/etcupdate.8
|
|
| Hi,
|
| there is a copy/pasto in etcupdate 1.64, the getopts variable name is "i",
| not "ch" (as in postinstall).
|
| r.
Good catch. It's in a codepath that shouldn't execute in practice, but
still worth fixing.
Luke.
| Index: usr.sbin/etcupdate/etcupdate
| ===================================================================
| RCS file: /cvsroot/src/usr.sbin/etcupdate/etcupdate,v
| retrieving revision 1.64
| diff -u -r1.64 etcupdate
| --- usr.sbin/etcupdate/etcupdate 9 Jan 2022 03:33:26 -0000 1.64
| +++ usr.sbin/etcupdate/etcupdate 16 Jan 2022 11:04:56 -0000
| @@ -554,7 +554,7 @@
| ;;
|
| *)
| - echo 1>&2 "${PROG}: Unimplemented option -${ch}"
| + echo 1>&2 "${PROG}: Unimplemented option -${i}"
| exit 3
| ;;
| esac
