Module Name: src
Committed By: jmcneill
Date: Sun Nov 1 12:13:21 UTC 2020
Modified Files:
src/sys/arch/arm/cortex: gicv3.c
Log Message:
Add an isb() barrier after ICC_SGI1R_EL1 write to prevent reordering with
subsequent wfi/wfe instructions. Haven't seen this in practice but I would
rather be safe here.
To generate a diff of this commit:
cvs rdiff -u -r1.29 -r1.30 src/sys/arch/arm/cortex/gicv3.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/arm/cortex/gicv3.c
diff -u src/sys/arch/arm/cortex/gicv3.c:1.29 src/sys/arch/arm/cortex/gicv3.c:1.30
--- src/sys/arch/arm/cortex/gicv3.c:1.29 Sun Nov 1 11:17:20 2020
+++ src/sys/arch/arm/cortex/gicv3.c Sun Nov 1 12:13:21 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: gicv3.c,v 1.29 2020/11/01 11:17:20 jmcneill Exp $ */
+/* $NetBSD: gicv3.c,v 1.30 2020/11/01 12:13:21 jmcneill Exp $ */
/*-
* Copyright (c) 2018 Jared McNeill <[email protected]>
@@ -31,7 +31,7 @@
#define _INTR_PRIVATE
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: gicv3.c,v 1.29 2020/11/01 11:17:20 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: gicv3.c,v 1.30 2020/11/01 12:13:21 jmcneill Exp $");
#include <sys/param.h>
#include <sys/kernel.h>
@@ -435,6 +435,7 @@ gicv3_ipi_send(struct pic_softc *pic, co
sgir |= ci->ci_gic_sgir;
}
icc_sgi1r_write(sgir);
+ isb();
}
static void
