Module Name: src
Committed By: rillig
Date: Sun Nov 22 09:48:58 UTC 2020
Modified Files:
src/usr.bin/make: suff.c
Log Message:
make(1): document possible bug in UpdateTarget in suffix handling
To generate a diff of this commit:
cvs rdiff -u -r1.283 -r1.284 src/usr.bin/make/suff.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/suff.c
diff -u src/usr.bin/make/suff.c:1.283 src/usr.bin/make/suff.c:1.284
--- src/usr.bin/make/suff.c:1.283 Sun Nov 22 09:46:37 2020
+++ src/usr.bin/make/suff.c Sun Nov 22 09:48:58 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: suff.c,v 1.283 2020/11/22 09:46:37 rillig Exp $ */
+/* $NetBSD: suff.c,v 1.284 2020/11/22 09:48:58 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@@ -114,7 +114,7 @@
#include "dir.h"
/* "@(#)suff.c 8.4 (Berkeley) 3/21/94" */
-MAKE_RCSID("$NetBSD: suff.c,v 1.283 2020/11/22 09:46:37 rillig Exp $");
+MAKE_RCSID("$NetBSD: suff.c,v 1.284 2020/11/22 09:48:58 rillig Exp $");
#define SUFF_DEBUG0(text) DEBUG0(SUFF, text)
#define SUFF_DEBUG1(fmt, arg1) DEBUG1(SUFF, fmt, arg1)
@@ -667,6 +667,12 @@ UpdateTarget(GNode *target, GNode **inou
!(target->type & OP_NOTARGET)) {
*inout_main = target;
Targ_SetMain(target);
+ /*
+ * XXX: Why could it be a good idea to return TRUE here?
+ * The main task of this function is to turn ordinary nodes into
+ * transformations, no matter whether or not a new .MAIN node
+ * has been found.
+ */
return TRUE;
}
