Module Name:    src
Committed By:   rillig
Date:           Sun Nov 22 11:11:43 UTC 2020

Modified Files:
        src/usr.bin/make: suff.c

Log Message:
make(1): fix type of local variable in FindDepsRegular

The compiler cannot check these since all lists and list nodes are
aliases to each other.

Maybe it's time to add type-generic lists to the code, to delegate these
checks to the compiler.


To generate a diff of this commit:
cvs rdiff -u -r1.289 -r1.290 src/usr.bin/make/suff.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: src/usr.bin/make/suff.c
diff -u src/usr.bin/make/suff.c:1.289 src/usr.bin/make/suff.c:1.290
--- src/usr.bin/make/suff.c:1.289	Sun Nov 22 10:27:56 2020
+++ src/usr.bin/make/suff.c	Sun Nov 22 11:11:43 2020
@@ -1,4 +1,4 @@
-/*	$NetBSD: suff.c,v 1.289 2020/11/22 10:27:56 rillig Exp $	*/
+/*	$NetBSD: suff.c,v 1.290 2020/11/22 11:11:43 rillig Exp $	*/
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -114,7 +114,7 @@
 #include "dir.h"
 
 /*	"@(#)suff.c	8.4 (Berkeley) 3/21/94"	*/
-MAKE_RCSID("$NetBSD: suff.c,v 1.289 2020/11/22 10:27:56 rillig Exp $");
+MAKE_RCSID("$NetBSD: suff.c,v 1.290 2020/11/22 11:11:43 rillig Exp $");
 
 #define SUFF_DEBUG0(text) DEBUG0(SUFF, text)
 #define SUFF_DEBUG1(fmt, arg1) DEBUG1(SUFF, fmt, arg1)
@@ -1748,7 +1748,7 @@ FindDepsRegular(GNode *gn, CandidateList
      * that still contain variables or wildcards in their names.
      */
     {
-	SuffixListNode *ln, *nln;
+	GNodeListNode *ln, *nln;
 	for (ln = gn->children->first; ln != NULL; ln = nln) {
 	    nln = ln->next;
 	    ExpandChildren(ln, gn);

Reply via email to