Module Name: src
Committed By: rillig
Date: Mon Feb 1 21:34:42 UTC 2021
Modified Files:
src/usr.bin/make/filemon: filemon_ktrace.c
Log Message:
make: document the syscalls that are not monitored by filemon_ktrace
To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 src/usr.bin/make/filemon/filemon_ktrace.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/usr.bin/make/filemon/filemon_ktrace.c
diff -u src/usr.bin/make/filemon/filemon_ktrace.c:1.13 src/usr.bin/make/filemon/filemon_ktrace.c:1.14
--- src/usr.bin/make/filemon/filemon_ktrace.c:1.13 Tue Jan 19 20:51:46 2021
+++ src/usr.bin/make/filemon/filemon_ktrace.c Mon Feb 1 21:34:41 2021
@@ -1,4 +1,4 @@
-/* $NetBSD: filemon_ktrace.c,v 1.13 2021/01/19 20:51:46 rillig Exp $ */
+/* $NetBSD: filemon_ktrace.c,v 1.14 2021/02/01 21:34:41 rillig Exp $ */
/*
* Copyright (c) 2019 The NetBSD Foundation, Inc.
@@ -761,6 +761,8 @@ filemon_sys_chdir(struct filemon *F, con
return syscall_enter(key, call, 1, &show_chdir);
}
+/* TODO: monitor fchdir as well */
+
/*ARGSUSED*/
static struct filemon_state *
filemon_sys_execve(struct filemon *F, const struct filemon_key *key,
@@ -832,6 +834,11 @@ filemon_sys_openat(struct filemon *F, co
const register_t *args = (const void *)&call[1];
int flags, fd;
+ /*
+ * XXX: In the .meta log, the base directory is missing, which makes
+ * all references to relative pathnames useless.
+ */
+
if (call->ktr_argsize < 3)
return NULL;
fd = (int)args[0];
@@ -860,6 +867,8 @@ filemon_sys_openat(struct filemon *F, co
}
}
+/* TODO: monitor the other *at syscalls as well, not only openat. */
+
/*ARGSUSED*/
static struct filemon_state *
filemon_sys_symlink(struct filemon *F, const struct filemon_key *key,
