John,

  I finally have my PC back and would like to get your fix in before the next build, which is happening any day now.  However, I have issues with it:

1. Needs commentary.  The JE didn't have much to begin with & that needs to improve.  So at least put in enough commentary that a reader can tell what you are doing without reading the C code. I put in an average of about one line of comment for each line of C.  As it stands it will me more time than I care to spend to verify that what you are doing is valid.

As part of the commentary, translate those long calls [amp(ds(CDIV...] to J.

2. AT(x)==INT is no good, because there may be flags set in more significant bits of the type.  Use (AT(x)&INT)

When you respond, send me your new testcase (gddot, I think) and point me to the fix, perhaps by simply sending me the new cd.c.

hhr
----------------------------------------------------------------------
For information about J forums see http://www.jsoftware.com/forums.htm

Reply via email to