Ulrich Klauer <ulr...@chirlu.de> wrote: > Eric Wong <normalper...@yhbt.net>: > > > === FLAC-related fixes (these are most important): > > > > 1) FLAC: encoding buffer overflow fix: > > https://sourceforge.net/tracker/?func=detail&atid=110706&aid=3474924&group_id=10706 > > Now in dot.
Thanks! > > 2) FLAC: fix MD5 check and code simplification > > https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3534117&group_id=10706 > > This doesn't identify a file with wrong checksum for me (even though > the file has been read completely; "flac --test" correctly complains). > > At the beginning of stop_read(), the decoder is in > *_SEARCH_FOR_FRAME_SYNC state, not *_END_OF_STREAM; but at the time > this is read, it is no longer valid anyway, because the previous call > to *_finish() "returns the decoder state to > FLAC__STREAM_DECODER_UNINITIALIZED" (API documentation). Thanks for looking at this. I'm not sure what drugs I was on that day... It made sense at the time :x Maybe it'll come back to me. > > soxi -b displays correct bitrate for Ogg-Vorbis > > https://sourceforge.net/tracker/?func=detail&atid=310706&aid=3591880&group_id=10706 > > Not sure about that. The question is what the bits-per-sample value is > to be used for. I'd think it should indicate the amount of space > consumed by one sample, in the file. But it arguably isn't very > consistent that bits-per-sample for FLAC is 24 then (or 8, or 16). Hmm... OK, now that I recall, I was a little confused on this, too. In any case, do we agree "soxi -b" showing "0" is incorrect? ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912 _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel
