-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 24 Feb 2009 19:35:44 +0530 Vikram Rai <[email protected]> wrote:
> Hi, > > We have started looking at the queries that need to be tagged. > In the initial stages of going through these queries we found a > couple of things and some ways we can tag them. > > Keeping in mind the diversity and complexity of the some of the > queries we have divided them into four categories: > > 1. Queries that need to have minor changes to make them work in > postgres. > > For eg: It could be like adding an "as" clause for alias names > etc. We had a suggestion to tag them with the following comment where > ever the changes are necessary: > > pgsql_c:xxx --> which is postgresql_comment:line number. > > 2. Queries that need to be rewritten. We had gone through a > couple of them as we went along the list and found some queries > that had to be rewritten to give an exact result. For eg: queries > on system catalogs in oracle do not work in postgres. > > we would be tagging such queries with the following comment: > > pgsql_q:xxx --> which is postgresql_query:line number. > > 3. Incase there are any db changes to accommodate a query using > Orafce, such queries would be tagged as: > > pgsql_orafce:xxx --> which is postgresql_database_change:line > number. > > 4. No changes required to the existing query. Works both on > postgres and oracle. > > pgsql_ora:xxx --> which is works on both postgres and oracle:line > number. > > These are just some initial thoughts and I am sure we will have > some additions to it down the road as we unfold some more of them. > Do let me know what you think. > > Regards, > > Vikram Rai > EnterpriseDB Looks pretty good, though could we sustitute pgsql_ with PGPORT_. I see almost no hits for pgsql_ but there may be some popping up in the future, PGPORT_ might be a little less grep hits down the road. Cheers, Devan - -- Devan Goodwin <[email protected]> Software Engineer Spacewalk / RHN Satellite Halifax, Canada 650.567.9039x79267 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkmkBMsACgkQAyHWaPV9my5UQwCggzIHFY9vFyfyVrQcFDKYWH9k z8EAoJKh7O3yN+KTEtzXpchB3ZIlJY8O =mE9m -----END PGP SIGNATURE----- _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
