Hey Vikram,
Thanks for putting the samples together. See below.
-jeff
Vikram Rai wrote:
Hi,
I have updated wiki with the process to tag the queries.
The below link would be used to track changes:
https://fedorahosted.org/spacewalk/wiki/PgportQueries
<https://fedorahosted.org/spacewalk/wiki/PgportQueries>
I don't think that the (spacewalk/documentation/...) paths are source code. Can someone
confirm? I also don't think there are queries in (.js) javascript files or stylesheets
(Eg: spacewalk/documentation/python-doc/epydoc.css ).
I'll edit/annotate the wiki page.
And the following link has examples for query tagging:
https://fedorahosted.org/spacewalk/wiki/QueryTaggingExamples
It was my understanding that the primary purpose for the tagging was to categorize the
queries into (1) of 4 categories. This means that the query was tagged as one of: 1,2,3
or 4. We then discussed that in addition to the (1-4) tag, additional information could
be captured. In the examples, it appears that samples 1 & 2 tagged as *both* #2 & #3
queries. When grep(ing) through the queries to see how many #2's we have and how many
#3's we have, won't this get confusing?
I added a 4th (Sample: 4) That is a consolidated version of Sample: 1 that show that that
while the query has discrepancies that could make it a #2, it also has discrepancies that
also make it a #3. Which, makes the query a #3.
I'm not saying that Samples 1-3 are wrong. Just saying that they differ from my
understanding about what Bruce originally suggested.
Regards,
Vikram Rai
EnterpriseDB
On Thu, Feb 26, 2009 at 4:12 AM, Bruce Momjian <[email protected]
<mailto:[email protected]>> wrote:
Here is where the query type numbers are defined:
https://fedorahosted.org/spacewalk/wiki/PostgresTechnicalApproach
---------------------------------------------------------------------------
Vikram Rai wrote:
> Hi,
>
> We have started looking at the queries that need to be tagged.
> In the initial stages of going through these queries we found
a couple
> of things and some ways we can tag them.
>
> Keeping in mind the diversity and complexity of the some of
the queries
> we have divided them into four categories:
>
> 1. Queries that need to have minor changes to make them work
in postgres.
>
> For eg: It could be like adding an "as" clause for alias
names etc.
> We had a suggestion to tag them with the following comment
where ever
> the changes are necessary:
>
> pgsql_c:xxx --> which is postgresql_comment:line number.
>
> 2. Queries that need to be rewritten. We had gone through a
couple of
> them as we went along the list and found some queries that had
to be
> rewritten to give an exact result. For eg: queries on system
catalogs in
> oracle do not work in postgres.
>
> we would be tagging such queries with the following comment:
>
> pgsql_q:xxx --> which is postgresql_query:line number.
>
> 3. Incase there are any db changes to accommodate a query
using Orafce,
> such queries would be tagged as:
>
> pgsql_orafce:xxx --> which is postgresql_database_change:line
number.
>
> 4. No changes required to the existing query. Works both on
postgres and
> oracle.
>
> pgsql_ora:xxx --> which is works on both postgres and oracle:line
> number.
>
> These are just some initial thoughts and I am sure we will
have some
> additions to it down the road as we unfold some more of them. Do
let me
> know what you think.
>
> Regards,
>
> Vikram Rai
> EnterpriseDB
> _______________________________________________
> Spacewalk-devel mailing list
> [email protected] <mailto:[email protected]>
> https://www.redhat.com/mailman/listinfo/spacewalk-devel
--
Bruce Momjian <[email protected] <mailto:[email protected]>>
http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
_______________________________________________
Spacewalk-devel mailing list
[email protected] <mailto:[email protected]>
https://www.redhat.com/mailman/listinfo/spacewalk-devel
------------------------------------------------------------------------
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
