Devan Goodwin wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Thu, 26 Mar 2009 09:24:28 -0400
Jason Dobies <[email protected]> wrote:
Problem we have is some of the commit logs are very wordy (which is
ok but the first sentence isn't descriptive enough) and others are
so terse that I don't bother including them: fixed unit test.
Would it be valuable to preface trivial commit messages with
something so they can be filtered out? I don't want to make an overly
complicated commit log process, but if generated change logs become
valuable it might be worth it.
At the same time, if the commit doesn't start with a BZ number can it
just be automatically considered trivial? One could make the argument
that any "changelog-worthy" work should have a BZ assigned to it.
Probably can't assume we're only interested in commits starting with a
bugzilla number, lot of changelog worthy stuff goes in without a bug.
Overall I'm not real keen on having rules on commit messages to
accommodate the changelog population. IMO it needs to remain a manual
process anyhow, and killing lines you're not interested in can be done
so easily regardless what $EDITOR you're using. Seems like a bad thing
to bind together and something we'd likely struggle constantly with
enforcing, after which we'd *still* probably have to review the results
manually.
Content to just "dd" the uninteresting lines on my end.
Agreed. By default I'd love it if tito would bring up my editor with
all the recent git log messages but allow me to edit it before the
commit. I wouldn't want it to default to just auto-concatting
everything into the commit log. That would tend to get a bit too verbose.
James, thanks for the patch! I was wishing for this earlier in the week,
Mike
--
Mike McCune
mmccune AT redhat.com
Engineering | Portland, OR
RHN Satellite | 650.567.9039x79248
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
