On Tue, Mar 31, 2009 at 09:50:26AM +0200, Jan Pazdziora wrote: > On Mon, Mar 30, 2009 at 10:37:12PM -0400, Jesus Rodriguez wrote: > > > > Thoughts? I suspect the lengths will cause folks to balk at this > > suggestion :) > > -1. > > I do not like restricting length of the first line of the commit > message to 50 character. In fact, I do not like restricting length of > the first line of the commit message at all.
Why not? The first line is simply a summary or the topic of the patch. You can be as verbose as you want in the body of the commit message. It's just like an email; you wouldn't put the whole body of the message in the subject. Frankly, if you can't summarize a change in 50 or so characters (I wouldn't place a hard limit, myself), then your change is probably doing more than one thing, and should be broken into smaller changes. > > -- > Jan Pazdziora > Senior Software Engineer, Satellite Engineering, Red Hat > > _______________________________________________ > Spacewalk-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-devel -James
pgp4QNGDemk3V.pgp
Description: PGP signature
_______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
