Thanks for you comments!
Jan Pazdziora wrote:
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote:
All,
I'd like to start getting some eyes on the pgsql branch in preparation of a
merge to
master. So far, the changes on this branch have been focused on porting the
schema and
updating the application infrastructure to work with both oracle and postgres
databases.
This might be a technicality but: do we want to merge or cherry pick?
If we want to start with infrastructure work, I assume we will want to
bring in the changes to master in small steps, addressing one issue at
a time (SQL standard compliance, table / trigger DDL split, etc.).
That way, the changes will have a chance to get verified and tested
in Oracle environment while the diff against the pgsql branch will
get smaller.
Yes, this would be nice.
I tried to keep the commits well grouped, it was a massive amount of work and the commits
were not necessarily grouped to be cherry picked. With that said, we can cheery pick
commits pertaining to schema/ re-factoring separately from code changes.
Given the scope of the changes it might be more conclusive to verify the schema changes by
querying (and comparing) the oracle (DDL) tables of two side-by-side oracle installs. One
installed from master and the other installed from pgsql. If they are deemed equivalent,
couldn't we deem the sources to be equivalent?
The alternative would be to manually re-implement most of the re-factoring work in another
branch and grouped into commits that can be reviewed and cherry picked into master. I
have no problem doing this but seem a waste to through away work that has already been
done and management would have to sign off on the additional effort. But, if the team
believes that this is the way to go, then ...
I would not want to see huge merge commit landing in master.
I understand your concern.
(I will probably send more responses to your post, commenting on
one issue at a time.)
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
