Jan Pazdziora wrote:
On Tue, May 12, 2009 at 12:42:32PM -0400, Jeff Ortel wrote:
- View files:
- Most view (.sql) files were (git) moved to common/views. This involved
some standardizing of the view SQL but most were unchanged.
Can you be more specific about the changes which were done? There are
some indentation changes (which might have been caused by the changes
that went to master in the meantime) which might not be needed, plus
trailing spaces (for example views/rhnAvailableChannels.sql).
This would be good to diff. They were only changed to the extent necessary to work for
both oracle and postgres (as far as I know).
Also, there are changes for the AS aliasing. I wonder if we could
easily drop the alias from Oracle (and pgsql) in cases when the alias
name is the same as column name -- for example
create or replace view rhnChannelFamilyOverview as
select pcf.org_id org_id,
f.id id,
f.name name,
That way, the diff which will introduce the AS will again be smaller.
Sure, so long as the DDL continues to work with both oracle and pg.
We also have views that have the column names specified right after the
view name:
create or replace view
rhnAvailableChannels
(
org_id,
channel_id,
channel_depth,
channel_name,
channel_arch_id,
padded_name,
current_members,
available_members,
last_modified,
channel_label,
parent_or_self_label,
parent_or_self_id
)
as
I wonder if this is the good time, regardless of the PostgreSQL port
state, to either adopt this style or drop it, for consistency reasons
(it should make writing validation parters for the schema easier as
well).
Sure. I'm very much in favor of standardizing.
- Few view (.sql) files were forked:
- (git) moved to oracle/views/
- Copied to postgres/views and ported to PG.
The views/rhnHistoryView.sql file seems to still contain definition of
rhnHistoryView_pkglist function. Is that correct?
Hmm... didn't expect to find function definitions in a view file so I didn't look. I
agree this function should be split out and the view.deps updated.
If we are touching
the file, we should really make sure anything which should not be there
is moved someplace else.
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
