On 08/14/2009 09:00 AM, Michael Mraka wrote:
Fedora Hosted Git Repositories - spacewalk.git/rss log: % Add spacewalk-backend Requires on python-pgsql. % % Add spacewalk-backend Requires on python-pgsql. % % • [DH] backend/spacewalk-backend.spec % % URL: http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h= % e56e4e9dc2959c28553350533a6b2dcea92a73f7 % --- a/backend/spacewalk-backend.spec % +++ b/backend/spacewalk-backend.spec % @@ -17,6 +17,7 @@ Requires: python, rpm-python % # /etc/rhn is provided by spacewalk-proxy-common or by spacewalk-config % Requires: /etc/rhn % Requires: rhnlib>= 1.8 % +Requires: python-pgsql % BuildRequires: /usr/bin/msgfmt % BuildRequires: /usr/bin/docbook2man % BuildRequires: docbook-utilsThis is wrong for 2 reasons: a) Such dependency should not be in spacewalk-backend but spacewalk-backend-sql package which is "Core functions providing SQL connectivity for the RHN backend modules". b) It means you have to install both oracle and postgresql for spacewak now which is weird. We should rather have meta dependency e.g. spacewalk-backend-db and spacewalk-backend-oracle and spacewalk-backend-postgresql packages which both provide spacewalk-backend-db and requires appropriate oracle/postgresql stuff. So you can install one or another. \
I agree with Michael here. Postgres deps should be a choice not a requirement. If I chose to use oracle why should I even care about installing python-pgsql ? I think meta dependency as Michael suggested seems like a better way than what we have here.
~ Prad
-- Michael Mráka Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
-- -- Pradeep Kilambi Senior Software Engineer RHN Satellite Engineering Phone: +1 919 754 4285 RHCE # 805008680430554 _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
