-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Fri, 14 Aug 2009 15:00:12 +0200 Michael Mraka <[email protected]> wrote:
> Fedora Hosted Git Repositories - spacewalk.git/rss log: > % Add spacewalk-backend Requires on python-pgsql. > % > % Add spacewalk-backend Requires on python-pgsql. > % > % • [DH] backend/spacewalk-backend.spec > % > % URL: > http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h= % > e56e4e9dc2959c28553350533a6b2dcea92a73f7 % --- > a/backend/spacewalk-backend.spec % +++ > b/backend/spacewalk-backend.spec % @@ -17,6 +17,7 @@ Requires: > python, rpm-python % # /etc/rhn is provided by > spacewalk-proxy-common or by spacewalk-config % Requires: /etc/rhn > % Requires: rhnlib >= 1.8 > % +Requires: python-pgsql > % BuildRequires: /usr/bin/msgfmt > % BuildRequires: /usr/bin/docbook2man > % BuildRequires: docbook-utils > > This is wrong for 2 reasons: > > a) Such dependency should not be in spacewalk-backend but > spacewalk-backend-sql package which is "Core functions providing SQL > connectivity for the RHN backend modules". > b) It means you have to install both oracle and postgresql for > spacewak now which is weird. > > We should rather have meta dependency e.g. spacewalk-backend-db and > spacewalk-backend-oracle and spacewalk-backend-postgresql packages > which both provide spacewalk-backend-db and requires appropriate > oracle/postgresql stuff. So you can install one or another. > > -- > Michael Mráka > Satellite Engineering, Red Hat > > _______________________________________________ > Spacewalk-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-devel Agreed on the short term, will move it to spacewalk-backend-sql. Agreed in the long term as well, we've known all along at some point we'll need to tease apart the Oracle deps and isolate them into a meta-package, same for PostgreSQL, it's just a matter of when we invest the time to do so. I don't know if now is the best time or how hard it'll be to isolate Oracle (the pgsql side should be easy, I think we only require two small deps now, python-pgsql and perl-DBD-Pg). Actually we could just setup the spacewalk-postgresql meta-pkg for now and leave Oracle until we're not actually tied to it. Sound ok? For the record I like the idea of: yum install spacewalk spacewalk-oracle yum install spacewalk spacewalk-postgresql Devan - -- Devan Goodwin <[email protected]> Software Engineer Spacewalk / RHN Satellite Halifax, Canada 650.567.9039x79267 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (GNU/Linux) iEYEARECAAYFAkqFbr4ACgkQAyHWaPV9my7PLQCgyzaHXwBR8ZMl9rDVKw7VSfUN tN0AnAi6u9oXoLvpHT2wTmgc2CcjFHyy =MOv2 -----END PGP SIGNATURE----- _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
