David Nutter wrote: % Hello, % % Here is a short patch which makes monitoring email notifications work % again for me. See thread "Monitoring and notifications" on % spacewalk-list for full details. % % The issue appears to be a reliance on MethodMaker returning a % reference to the underlying storage for list-type class members. This % no longer happens in MethodMaker 2.0.8, the current version in EPEL 5.
Reviewed & applied. % There is a wider issue of reliance on Class::MethodMaker::V1Compat % throughout the NOCPulse perl code which may well be causing other % bugs/issues as the compatibility module is not 100% compatible. % % I considered submitting patches to fix this as well but I think % there's too much code to change at once, especially for a n00b like % me. Most of the changes seem to be trivial such as rewriting the class % initialisation code in V2 style. Since monitoring notifications are % now working for me I'm not sure this really qualifies as a bug. Please % advise me on how to proceed. Don't be affraid to change the code - we are doing reviews so there will be at least one more eye to catch bugs ;). It's always good idea to split big code changes into several relatively small commits (one commit per issue with descriptive comments) than one mega commit. Thanks for the contribution. -- Michael Mráka Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
