On Fri, Mar 11, 2011 at 12:01:28PM +0100, Uwe Gansert wrote: > on Thursday 10 March 2011 Justin Sherrill wrote: > > > > --- > > > a/java/code/src/com/redhat/rhn/frontend/action/kickstart/tree/BaseTreeAct > > >ion.java +++ > > > b/java/code/src/com/redhat/rhn/frontend/action/kickstart/tree/BaseTreeAct > > >ion.java @@ -30,6 +30,7 @@ import org.apache.struts.util.LabelValueBean; > > > > > > import java.util.Iterator; > > > import java.util.List; > > > +import java.net.*; > > > > We generally don't include entire packages without our code. Please > > only include the specific classes that you are using. > > I have attached a new patch. The new patch does not have that import anymore. > > > While this works, typically we would prefer to use the request to get > > the hostname. HttpServletRequest.getLocalName() should get you the > > hostname that the request comes in on. You would have to change the > > method signature of processCommandSetters to accept the request, but > > that is a better way to get the hostname IMHO. > > I did it like you suggested. I hope I'll find some time to enhance cobbler in > the future to parse kopts and replaces variables but for the moment we can > live with the solution I have attached I think. > > Patch attached.
I've now pushed the patch to master as ef27f021d35462cbc6c4e58cdf71b97270b85076 and tagged as spacewalk-java-1.5.7-1. I'm sorry that it took me so long to process it. Thank you, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
