Hi Jan,
Ok, i can take a look on this next week.

Regards.

Baptiste

----- Mail original -----
De: "Jan Pazdziora" <jpazdzi...@redhat.com>
À: spacewalk-devel@redhat.com
Envoyé: Jeudi 18 Août 2011 13:39:57
Objet: Re: [Spacewalk-devel] [PATCH] Filters on reposync

On Wed, Aug 17, 2011 at 08:23:36PM +0200, Baptiste AGASSE wrote:
> 
> Following your advices I have modified my code:
> - You can now include and / or exclude packages (with --include and / or 
> --exclude options)
> - Include filter takes priority over exclude filter: if one package meet 
> 'include' and 'exclude' rules, it will be included
>   eg:
>     exclude = [ 'openoffice.org-langpack-*', ...]
>     include = [ 'openoffice.org-langpack-en-*', ...]
> 
> - Package filtering is in yum_src.py
> - Yum dependencies resolver is now used to find selected packages dependencies
> - All versions of the packages excluded by a filter is now deleted from DB 
> and filesystem
> - Print elapsed time at end of sync
> 
> Any comments are welcome.

I don't really like the fact that the exclude/include options are
specified on the spacewalk-repo-sync runtime, rather than being
properties of the repository. In other words -- these exclude/include
lists should be specified in the database, so that they would be used
any time spacewalk-repo-sync is run, no matter if it is run from the
command line or via scheduled event by taskomatic.

Now that the core functionality is in place, could you amend it some
more and have the lists stored in some database table and used from
there?

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to