Baptiste AGASSE wrote:
% Hi Michael,
Hi Baptiste,
% Following your advices I have modified my code:
% - You can now include and / or exclude packages (with --include and / or
--exclude options)
% - Include filter takes priority over exclude filter: if one package meet
'include' and 'exclude' rules, it will be included
% eg:
% exclude = [ 'openoffice.org-langpack-*', ...]
% include = [ 'openoffice.org-langpack-en-*', ...]
my original idea was to be able to stack includes / excludes on top of
each other, e.g.
include=openoffice.org-*
exclude=openoffice.org-draw,openoffice.org-langpack*
include=openoffice.org-langpack-en,openoffice.org-langpack-de
which in the end will sync openoffice.org packages except *-draw and
*-langpacks but will also include *langpack-en and *langpack-de.
% - Package filtering is in yum_src.py
% - Yum dependencies resolver is now used to find selected packages dependencies
The filtering and dependecy resolver parts look good. I'm not keen on
inheriting ContentSource from yum.YumBase because it leads to implicit
import of all yum repos defined in the server's /etc/yum.repo.d/ which have
nothing to do with repos defined in Spacewalk (the application). Morever
you have to delete them so they not mess up with the valid spacewalk
repos.
% - All versions of the packages excluded by a filter is now deleted
% from DB and filesystem
Well, this changes current behavior of spacewalk-repo-sync because we
never remove packages which are already in the channel during sync
process. E.g. you might have packages pushed manually (via rhnpush) into
channel, should they also be removed? I don't think so.
I decided skip this part of patch for now.
% - Print elapsed time at end of sync
%
% Any comments are welcome.
I went through your patch, modified it according to my comments above
and applied to master. Now I'm going to look at the database part.
Thanks for your contribution.
% Regards.
%
% Baptiste
Regards,
--
Michael Mráka
Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
