[Spacewalk-devel] [PATCH] - 741476 API system.getDmi() method does not return data when SYSTEM field at RHNSERVERDMI table is null

[Marcelo Moreira de Mello]

Hello Team,

  Follow a patch addressed to BZ at $subject.  Created an test package
and worked as expected.

   After applied the patch, the results work as expected.


 Best,
mmello

-- 
Marcelo Moreira de Mello
RHCA RHCSS RHCVA 
Senior Software Maintenance Engineer/SEG           

gpg id: 2048R/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309  8F18 BD42 D095 FDB1 10E5


From: Marcelo Moreira de Mello <mme...@redhat.com>
Date: Tue, 4 Oct 2011 18:36:16 -0300
Subject: [PATCH] 741476 - fixed API system.getDmi() method does not return data 
when SYSTEM field at RHNSERVERDMI table is null

---
 .../frontend/xmlrpc/serializer/DmiSerializer.java  |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)

diff --git 
a/java/code/src/com/redhat/rhn/frontend/xmlrpc/serializer/DmiSerializer.java 
b/java/code/src/com/redhat/rhn/frontend/xmlrpc/serializer/DmiSerializer.java
index 7fb29ad..dcd94a6 100644
--- a/java/code/src/com/redhat/rhn/frontend/xmlrpc/serializer/DmiSerializer.java
+++ b/java/code/src/com/redhat/rhn/frontend/xmlrpc/serializer/DmiSerializer.java
@@ -59,15 +59,11 @@ public class DmiSerializer implements 
XmlRpcCustomSerializer {
         SerializerHelper bean = new SerializerHelper(builtInSerializer);
         Dmi dmi = (Dmi) value;
 
-        if (dmi.getSystem() == null) {
-            return;
-        }
-
-        bean.add("vendor", StringUtils.defaultString(dmi.getVendor()));
-        bean.add("system", StringUtils.defaultString(dmi.getSystem()));
-        bean.add("product", StringUtils.defaultString(dmi.getProduct()));
-        bean.add("asset", StringUtils.defaultString(dmi.getAsset()));
-        bean.add("board", StringUtils.defaultString(dmi.getBoard()));
+        bean.add("vendor", 
StringUtils.defaultString(dmi.getVendor()==null?"":dmi.getVendor()));
+        bean.add("system", 
StringUtils.defaultString(dmi.getSystem()==null?"":dmi.getSystem()));
+        bean.add("product", 
StringUtils.defaultString(dmi.getProduct()==null?"":dmi.getProduct()));
+        bean.add("asset", 
StringUtils.defaultString(dmi.getAsset()==null?"":dmi.getAsset()));
+        bean.add("board", 
StringUtils.defaultString(dmi.getBoard()==null?"":dmi.getBoard()));
         bean.add("bios_release", 
StringUtils.defaultString(dmi.getBios().getRelease()));
         bean.add("bios_vendor", 
StringUtils.defaultString(dmi.getBios().getVendor()));
         bean.add("bios_version", 
StringUtils.defaultString(dmi.getBios().getVersion()));
-- 
1.7.6.4


_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel