Hello Jan,
Reviewing it.. Hope to provide an update into this ASAP.
Thank you for heads up. Working into this.
Best,
mmello
Marcelo Moreira de Mello
RHCA RHCSS RHCVA
Senior Software Maintenance Engineer - SEG
gpg id: 2048/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309 8F18 BD42 D095 FDB1 10E5
On Oct 5, 2011, at 4:03 AM, Jan Pazdziora wrote:
> On Tue, Oct 04, 2011 at 07:13:31PM -0300, Marcelo Moreira de Mello wrote:
>> Hello Team,
>>
>> Follow a patch addressed to BZ at $subject. Created an test package
>> and worked as expected.
>>
>> After applied the patch, the results work as expected.
>
> Nack.
>
> The first part of your patch reverts change for bug 452956. Unless we
> know *exactly* why that change was done for that bug (in other words,
> reproduce that original bug, without that patch), we risk a regression
> here.
>
> The second part of your patch seems like a noop to me since
> StringUtils.defaultString is defined as
>
> Returns either the passed in String, or if the String is null,
> an empty String ("").
>
> already.
>
> --
> Jan Pazdziora
> Principal Software Engineer, Satellite Engineering, Red Hat
>
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
