On Thursday 12 of April 2012 11:32:05 Duncan Mac-Vicar P. wrote: On 04/11/2012 11:00 AM, Tomas Lestach wrote: This is ok, because it's not used in the elaborator. Regards, Ok, here is a patch for review for the first part: adding a list of systems that need review, and showing a notification in the system detail that it needs reboot with a link to the action.
Screenshots: http://imgur.com/z8Y9u http://imgur.com/oLE4H I am still missing something. In the query I am doing: AND EA.errata_id = E.id AND to_timestamp(S.last_boot) < SA.completion_time This to_timestamp() only works (with those types) in Postgres. The problem is that both attributes have different types: numeric & timestamp in Postgres, numeric & date in oracle. But Oracle's to_timestamp takes a char. Any ideas how to make this query work across both? I hope a PL/SQL is not the the path :-/ Duncan Hey Duncan, I reviewed your patch and here're my comments: - please rename one of the having_errata_with_keyword_applied_since_last_reboot query or mode - not to have the same name - even if it does not cause any troubles, it's better for later greps :-) - requiresReboot method with its queries is unacceptable - I'm not sure, if you didn't understand what I already tried to explain, but you cannot run the whole having_errata_with_keyword_applied_since_last_reboot query accross all the registered systems and their errata, when you need and information about one single system - this is highly inefficient Imagine you have 10000 systems registered and tens of channels with hundreds of errata. You cannot join all these information to find out, whether one particular system needs a reboot Otherwise the patch look good. Regards, Tomas -- Tomas Lestach RHN Satellite Engineering
_______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
