On Friday 13 of April 2012 12:29:40 Duncan Mac-Vicar P. wrote: > On 04/12/2012 02:46 PM, Tomas Lestach wrote: > > - please rename one of the > > having_errata_with_keyword_applied_since_last_reboot query or mode - not > > to > > have the same name > > > > - even if it does not cause any troubles, it's better for later greps > > :-) > > Ok. Originally I named them differently, then looking at the code I saw > others with the same name and followed that as example. :-/ > > > - requiresReboot method with its queries is unacceptable > > > > - I'm not sure, if you didn't understand what I already tried to > > explain, > > > > but you cannot run the whole > > having_errata_with_keyword_applied_since_last_reboot query accross all the > > registered systems and their errata, when you need and information about > > one single system - this is highly inefficient > > Imagine you have 10000 systems registered and tens of channels with > > hundreds of errata. You cannot join all these information to find out, > > whether one particular system needs a reboot > > Thanks for pointing it out. I am unsure how to solve it without > duplicating (copy pasting) the whole query, as the way the elaborator > works, I can just append "%s and S.id=:sid" or add a inner join. > > If it is acceptable to duplicate the query, slightly modified to have a > inner join or a and clause so that the query is done for the single > system I can do that. This framework confuses me.
A separate query for a single system would definitelly be more efficient. > > Any comments about the to_timestamp() and Oracle? Check the PG sql porting guide. https://fedorahosted.org/spacewalk/wiki/PostgreSQLPortingGuide Tomas -- Tomas Lestach RHN Satellite Engineering _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
