On Tuesday 06 of November 2012 12:30:09 Johannes Renner wrote: > Hello, > > this is a proposed extension to commit 1ea830a in master: > > Validation of a kickstart profile is currently done by downloading it from > the locally running cobbler. In case of validation problems there is a > DownloadException thrown that we can catch and work with. > > Therefore in case of an error, it makes IMO not very much sense to point to > the 'Kickstart File' tab, where the downloaded file contents should > actually be shown to the user. The cobbler returns a status 500 in this > case, so what we see on this page is the source code of the apache error > page. Further, the download link is of course not working.
Right. I see your point. > > The attached patch contains the following proposed changes to the code: > > 1. Change the error message text to point to the file contents on the > 'Details' tab 2. Hide the content on the 'Kickstart File' tab in case the > download failed The problem with your patch is that you don't propagate any helpful (error) message to the user. So if he uploads a kickstart file, that is considered wrong for some reason, I - as an user - would like to know what was the problem with the kickstart file. I know that the 500 page we display now isn't helpfull as well. I'll try check the code and see if I find something out. > > Regards, > Johannes Regards, -- Tomas Lestach RHN Satellite Engineering _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
