> Yes, my cobbler log contains some helpful info, but how to bring this
> excerpt to the UI if we are only reacting to a download that failed? I
> didn't dig deep into it, I just wanted to hide the html source of the 500
> error page. But I agree it would be much better to present such details to
> the user.

I patched our cobbler, because in cause of a cheetah error it returned 
different output for rhel5(mod_python) and rhel6(mod_wsgi). Now, we shall get 
500 with the error in the response body in both cases.

On WebUI for these cases - I removed the 'Download Kickstart File' link, 
displayed an error message and changed the error backgrond to make sure the 
user notices the problem.

Let me know if you still would like to make some changes.

> 
> Excerpt from cobbler.log:
> 
> ...
> Here is the corresponding Cheetah code.
> ** I had to guess the line & column numbers, so they are probably incorrect:
> 
> Line 47, column 8
> 
> Line|Cheetah Code
> ----|-------------------------------------------------------------
> 44  |
> 45  |mkdir -p /tmp/rhn
> 46  |
> 47  |drives=$(list-harddrives | awk '{print $1}')
>             ^
> 48  |for disk in $drives; do
> 49  |    DISKS="$DISKS $(fdisk -l /dev/$disk | grep -v "swap\|LVM\|Extended"
> | awk '/^\/dev/{print $1}')"
> 50  |done
> ...
> 
> BTW: This error occurred with a kickstart file that was generated using the
> wizard and pasted into the new profile form afterwards. The cheetah seems
> to complain about the $ signs in the bash code and wants me to escape them.
> Actually I would expect this to work, or not? Not so sure how the cheetah
> will distinguish between bash $ signs and kickstart variables?

Right, this is the behavior I know since my first tries with Spacewalk 
kickstart profiles. I mean it's because of the templating feature.
You either have to escape the dollar signs or have to put the dollar 
containing code into the #raw..#end block.

> 
> Thanks,
> Johannes

Related commits:
 747754ef
 74aa5047
 d1789a9e

Regards,
-- 
Tomas Lestach
RHN Satellite Engineering

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to