Hello,
I would like to thank you for your contribution. However we found some
issues while reviewing the patch
On 08/12/2013 06:34 PM, Bo Maryniuk wrote:
Hi!
In the System Set Manager (SSM) there are two separate Perl pages in the Misc
section:
1. Lock
2. Unlock
Selecting systems to lock or unlock as a subset of SSM looks bit weird.
The purpose of SSM is that once you've selected a set of systems you
work with them with them as with a batch. Take a look at other pages of
SSM as there are no more selections and you work with the whole set.
Here is a patch, which does the following:
1. Now it is only one page where you can lock and unlock systems.
I've found a bug there, when you try to lock a locked system you will
actually unlock them. I would expect them to stay locked.
2. Since this is SSM and batch move, there is a mandatory field, where admin
must give the reason for [massive] systems lock. There is no such thing
when locking one system, however it is a very good idea to have it in SSM
to prevent operation troubles.
Nice change, however I would like to have the reason field not mandatory.
Also bashing enter in the reason field causes the page to reset. I would
expect something to happen like lock of systems in SSM not just to reset
the page. In my opinion it's typical user behaviour to bash enter after
filling the form so this and the selection of subset from SSM hurts page
usability.
3. Brings back the sub-menu of the Misc.
I like this :-)
4. Implementation is all in Java.
That's great ;-)
Take care and have a nice weekend!
_______________________________________________
Spacewalk-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-list
Also a note the line "* Copyright (c) 2013 SUSE" breaks our checkstyle.
Now we have a rule that copyright must be "Red Hat, Inc." || "Novell".
Also moving this conversation to spacewalk-devel which is better place
to discuss about development of Spacewalk and sending patches.
--
Tomáš Kašpárek
Red Hat Satellite 5, Red Hat
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
