Hi, Tomáš! On Tue, Aug 13, 2013 at 11:31:34AM +0200, Tomáš Kašpárek wrote: > Selecting systems to lock or unlock as a subset of SSM looks bit > weird. The purpose of SSM is that once you've selected a set of > systems you work with them with them as with a batch. Take a look at > other pages of SSM as there are no more selections and you work with > the whole set.
True. However there is still a niche for this. For example, you have a set of some specific machines that runs one type of software and you want to run some batch on them, except few. > >Here is a patch, which does the following: > >1. Now it is only one page where you can lock and unlock systems. > I've found a bug there, when you try to lock a locked system you > will actually unlock them. I would expect them to stay locked. Fixed. > Nice change, however I would like to have the reason field not mandatory. Fixed. > Also bashing enter in the reason field causes the page to reset. Fixed. For now I've just disabled the Enter key for the field, as it is very unclear what to do and how exactly. Let our users continue use mouse at this moment. :) With the Twitter Bootstrap (TB) we will surely go back to here and offer something better. I also don't want to add much other code, which might go away, after we move everything to the TB. So I hope, for now our users will perfectly live with by bashing enter key, seeing nothing happens, and thus clicking mouse where required. > >3. Brings back the sub-menu of the Misc. > I like this :-) Not included in this patch though, but I've also replaced the whole Misc indes page with something much more simpler, leaving only bottom form and not-yet-ported "Custom System Information" Perl pages (to simply kick them away from the menu on top entirely) and putting all the rest stuff to the submenu. This way it looks much better. With our effort migrating everything to Twitter Bootstrap, I will soon port "Custom System Information" as well, so they will also go away from the index page and appear in the sub menu. > Also a note the line "* Copyright (c) 2013 SUSE" breaks our > checkstyle. Now we have a rule that copyright must be "Red Hat, > Inc." || "Novell". > Also moving this conversation to spacewalk-devel which is better > place to discuss about development of Spacewalk and sending patches. Well, this is no longer true as we lately use "SUSE" in the copyrights. Therefore please apply patch #0002 for this. Take care! -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer I used to have a handle on life, but it broke.
0001-Ported-from-Perl-to-JPS-locking-and-unlocking-page-c.patch.bz2
Description: application/bzip
0002-Accept-SUSE-copyright.patch.bz2
Description: application/bzip
_______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
