On 09/12/13 07:45, Duncan Mac-Vicar P. wrote:
On 09/12/13 05:32, Jan Pazdziora wrote:
(and code attached)
Nice idea.
There is a problem with the general inconsistency of the date/time
displays, and part of it stems from the fact that Java does it
differently than Perl.
What is the proposal for the Perl side of the code base? If there is
going to be some mass deployment of the new tags, it would be good to
make it a full audit of the time formatting usage and do it
everywhere.
mmmm... Johannes was pushing for the moment.js option (client side) and
I convinced him on the server-side solution, but I did not think about
perl. Doing it client side would solve the problem.
I will try a different implementation using moment.js.
Of course, how much perl code is to remain, soon?
- So, that maybe is something that can be mitigated with plan to
continue converting perl pages to java.
Client side rendering via js is reasonable - dumb question - where/what
does the locales? :)
- I do like the screen shots and idea of making date/time stuff easier
to read - I've also seen people wanting date formatting displayed
changed. Just because their language is English, doesn't mean that
11/12/13 is clear to them - since in America is is 12th November and in
UK it is 11th December.
And of course -- there may be people who prefer the exact dates/times
to be shown so this really should be configurable. For new
deployment/users, I assume the new behaviour would be fine but for
existing users, we might want to preserve the existing behaviour,
and let the users change it manually.
I disagree in making configurable (software complexity increases a lot
adding little value), but if in order to get the patch upstream it is
needed, with the client-side solution this should not be hard to achieve.
I agree that I disagree with Jan here. I know some may grumble, but
where it matters, within spacewalk-reports, APIs, etc - the data is
given in usable/precise manner.
If done client js, they can use browser plugin's to disable execution of
specific js's, so it would render the old way.
Cliff
Duncan
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
