On 12/20/2013 05:15 PM, R P Herrold wrote: > On Fri, 20 Dec 2013, Maximilian Meister wrote: > >> this patch would add a bootstrapified password strength >> meter to all pages where user details are being created or >> edited (create the initial admin user, create/edit normal >> users and create organization). There is also a tick icon on >> the side of the password input fields, which checks if the >> value in the desired password field will be accepted by the >> server and if the value in the confirm password field >> matches the value in the desired password field. > > This seems to pull in new dependencies, doesn't it? It is not > really clear to me that doing passwd strength testing here, > 'one off' per package makes sense, rather than having a > general interface to query a facility that many packages > beyond just spacewalk could use
Maximilian's patch is in fact based on a third party plugin for Twitter Bootstrap: https://github.com/ablanco/jquery.pwstrength.bootstrap I agree that in fact it would be good practice to package the plugin javascript file, so it can be used beyond spacewalk as you are suggesting. In case Maximilian has upstreamed all the changes he made I would propose him to do that. But please also note that Spacewalk included libraries like prototype-1.6.0 and scriptaculous since 2008, and these were never put into separate packages so far! Now these were exchanged for bootstrap, jquery and less, so yes: I agree that all those libs should ideally be separate packages, but it's a general problem that is not specific to this password strength meter proposal. > Also, how would this interact with non-local > authentication interfaces such as LDAP? Just as Silvio wrote, it won't. It really is only for giving immediate feedback to users about the strength of a proposed password while typing. Regards, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
