Hi Maximilian.
I see you have made some nice work there but there are still few things
that need to be fixed.
* Warning pop-up.
* Could it be moved to the right or bottom of the filed?
* It also blinks/flickers on change, is there a way to stop it?
* Colored progress bar/strength meter.
* It is connected with the password field in very strange way (visually).
Would it be possible to change it as per Michael's suggestion
to look like [1] or [2]? Personally I would prefer second option.
* Spec
* `jquery.pwstrength.bootstrap` is not good name for package. I suggest
`pwstrength-bootstrap` (the .spec is called such anyway).
* `Source0` is defined in a bit complicated way. Using
[4] would not only be sufficient but will make it clearer and
easier to understand.
* Is there simple way to change rules that determine what is acceptable
password?
* E.g. various "character classes" reminded me
there are other ways to make good password :-). [3]
Thanks for the effort invested and keep up good work :-).
[1]
http://www.jqueryscript.net/demo/Simple-jQuery-Password-Strength-Indicator-Plugin-passMeter/
[2]
http://cdn1.freshdesignweb.com/wp-content/uploads/2011/09/jquery-password-strength-meter-005.jpg
[3] http://xkcd.com/936/
[4] https://github.com/ablanco/jquery.pwstrength.bootstrap/archive/1.0.2.tar.gz
Sincerely
--
Matej Kollar
Satellite Engineering, Red Hat
----- Original Message -----
> From: "Maximilian Meister" <mmeis...@suse.de>
> To: spacewalk-devel@redhat.com
> Sent: Thursday, January 23, 2014 2:08:56 PM
> Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to
> spacewalk
>
> On 01/23/2014 11:04 AM, Michael Mraka wrote:
> >
> > Hi Maximilian,
> >
> > that sounds great.
> >
> > % Question is now do I need to package the second .js as well? Or can
> > % i simply add it to the git tree
> > % in web/html/javascript?
> >
> > If it's spacewalk specific (I think so) then just put it to
> > web/html/javascript
> > next to other spacewalk-*.js.
> >
>
> Hi,
>
> here is the new patch with the
> * recent release of jquery.pwstrength.bootstrap
> * a spec file to build a package from it
> * the patch to the sources during rpmbuild
> * the customization/caller script + a function to generate the tick icon
> * custom styles for the password strength meter
>
> please have a look.
> Thanks
>
> --
> --
> Mit freundlichen Grüßen,
> Maximilian Meister
> Systems Management Department
>
> SUSE LINUX Products GmbH
> Maxfeldstr. 5
> D-90409 Nuremberg, Germany
>
> http://www.suse.com
>
> GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg)
>
>
> _______________________________________________
> Spacewalk-devel mailing list
> Spacewalk-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/spacewalk-devel
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
