Hello,
----- Original Message -----
> From: "Duncan Mac-Vicar P." <dmacvi...@suse.de>
> To: spacewalk-devel@redhat.com
> Sent: Wednesday, June 10, 2015 2:00:06 PM
> Subject: [Spacewalk-devel] Getting rid of Repository Checksum Type "None"
>
> Hi
>
> While fixing our testsuite to run with PhantomJS, we hit a clunky part:
>
> - One is that when adding a channel, default checksum is sha1, parent
> channel None. But:
> - Changing the parent channel, triggers changing the checksum / arch
> to the parent channel one
> - Except if you select Parent: None again, Checksum will be None (and
> not sha1) -> BUG (and we can fix it and make a PR)
>
> So to fix that bug, we found out that a None checksum makes taskomatic
> silently skip that channel for metadata generation which could be very
> confusing for users:
>
> if (checksumtype == null) {
> generateBadRepo(channel, prefix);
> return;
> }
>
> So I was thinking to add a better log entry and may be a warning in the
> channel details page, but...
>
> If we don't generate metadata for "None", and this option is not part of
> checksumtype table, but manually added in the form:
>
> List<Map<String, String>> checksums = new ArrayList<Map<String, String>>();
> addOption(checksums, ls.getMessage("generic.jsp.none"), "");
> for (ChecksumType chType :
> ChannelFactory.listYumSupportedChecksums()) {
> addOption(checksums, chType.getLabel(), chType.getLabel());
> }
>
> Why not removing the "None" option alltogether? Does anyone see a reason
> to keep it?
>
According to tooltip in Spacewalk - 'Yum repository checksum type 'None' is
supported only for RHEL 3 and RHEL 4.'. I suppose we can remove this support
since we don't support these old RHELs anyway. I see you already created PR for
this bug, probably would be better to drop None checksum support first.
> Regards,
>
> --
> Duncan Mac-Vicar P. - http://www.suse.com/
>
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu,
> Graham Norton, HRB 21284 (AG Nürnberg)
> Maxfeldstraße 5, 90409 Nürnberg, Germany
>
Regards,
--
Jan Dobes
Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
