Malte -

I see you checked in an update. There are a few problems remaining that you would not be able to see without trying it under Windows:

In build/configure change w32.lib to w2_32.lib

(That was my typo originally. Sorry)

$ svn diff build/configure
Index: build/configure
===================================================================
--- build/configure     (revision 4630)
+++ build/configure     (working copy)
@@ -61,7 +61,7 @@
     MAKEFILE       => 'binaries.mk',
     SRCDIR         => $args{srcdir},

-    LIBS           => 'ws32.lib',
+    LIBS           => 'ws2_32.lib',
     SSLLIBS        => 'ssleay32.lib libeay32.lib',

     SPAMC_FILES    => 'spamc.c getopt.c',

===================

In Makefile.PL near line 297 there is the line

delete $makefile{EXE_FILES}['spamd/spamd'];

It only executes under Windows, which is why you didn't run into it.

Obviously 'spamd/spamd' is not an array index :-)

You either want it to be

  delete $makefile{EXE_FILES}[4];

or maybe the above but define a constant to 4

or simply

  delete 'spamd/spamd';

Depending on your sense of aesthetics.


$ svn diff Makefile.PL Index: Makefile.PL =================================================================== --- Makefile.PL (revision 4630) +++ Makefile.PL (working copy) @@ -296,7 +296,7 @@ # Windows platforms need some adjustments if (RUNNING_ON_WINDOWS) { # Don't build spamd - delete $makefile{EXE_FILES}['spamd/spamd']; + delete $makefile{EXE_FILES}[4]; # And require Net::DNS v0.44 #$makefile{PREREQ_PM}{Net::DNS} = 0.44; }

===============

In spamd/binaries.mk.win you use make where you should use $(MAKE) which breaks the build under Windows using nmake.

$ svn diff spamd/binaries.mk.win
Index: spamd/binaries.mk.win
===================================================================
--- spamd/binaries.mk.win       (revision 4630)
+++ spamd/binaries.mk.win       (working copy)
@@ -17,7 +17,7 @@

 $(SRCDIR)/spamc.exe:
        cd $(SRCDIR)
-       make -f $(MAKEFILE) spamc.exe
+       $(MAKE) -f $(MAKEFILE) spamc.exe


spamc.exe: $(SPAMC_FILES) $(LIBSPAMC_FILES)

============

And finally, for the tests to run under Windows and Cygwin you need to check in the patches I submitted with bug #2479 for spamd/spamd.raw and all the stuff in the t/ directory.

=============

Let me know when that's in and I'll do another round of tests.

 -- sidney



Reply via email to