On Thu, Jan 22, 2004 at 12:59:16AM +0100, Malte S. Stretz wrote: > > My recent Bayes Storage work has greatly improved this. I was able to > > add a new RPC based storage module in a very short time. Not to > > mention the fact that it can be made even better, it was too great a > > leap IMO for the first pass at making it easier to extend. My plan is > > that once I've got things stable and working well (close) and > > hopefully merged in, I'll continue to extract implementation specific > > methods and what not out of the storage code. > > > > Interestingly, the AWL stuff was VERY easy to expand, but it is much > > simpler than the bayes storage code. > > Where is that stuff? If it's in a bug it must have slipped through under my > radar. Could you give me a pointer? >
http://bugzilla.spamassassin.org/show_bug.cgi?id=195 The patch is due an update (just a couple of minor conflicts the last couple of days, nothing major). > > > > I've also been thinking about this. In general we've got two general > > ways we access data, key/value pairs and more specialized access (ie > > BayesStorage). > > Here I thought about very lowlevel function like opening the database, > errorhandling and "raw" reading stuff. Everything else should go into the > other Store*.pm. > Right, make Store.pm handle key/value pairs (along with getting a subsystem and username) and push all implementation into Store*.pm modules. I might whip something up for this in a couple of days as a proof of concept. Michael
