-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matt Sergeant writes:
>On 21 Jan 2004, at 21:55, Malte S. Stretz wrote:
>
>> * Some stuff from Matt's sa-3.0 stuff? I didn't look at it again 
>> because I
>> didn't want to get "tainted" by non-ASL code.
>
>There's not much to see there, and I'd do it differently now anyway.
>
>Mostly I think you're on the right track though, so I'll just shutup 
>and leave you to it :-)
>
>(I am an ASF committer though - the ASF just lost my CLA - so my sa3 
>work shouldn't be considered "tainted" in any sense).

However parts of the sa3 branch contain code copied from the spamassassin
branch verbatim -- which may or may not be covered by CLAs.

But the object model -- which Matt redid -- is safe.

BTW one key benefit of Matt's approach was to decouple parts of
PerMsgStatus into:

    - overall check() method; the code that calls into tests,
      decides when to stop, combines the results into a final score

    - run_foo_tests() methods for each type of test; the code
      that implements running particular test types.

    - helper fns: get(), get_decoded_stripped_blah_array() etc.

this would be useful.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFAEB1tQTcbUG5Y7woRAlETAKCS04tmSv8XX/fNQfqXAP2EHBpCuACgxU80
majuXxEwLbwrijhQW9AFTKk=
=IDsC
-----END PGP SIGNATURE-----

Reply via email to