http://bugzilla.spamassassin.org/show_bug.cgi?id=3064
------- Additional Comments From [EMAIL PROTECTED] 2004-03-01 10:08 ------- Subject: Re: sa-learn should ignore "use_bayes 0" setting On Mon, Mar 01, 2004 at 08:12:06AM -0800, [EMAIL PROTECTED] wrote: > At first I thought, maybe a new config param, use_salearn, but I don't > think we need to complicate things. I just did a quick run through of > all the places that check use_bayes and it's not many. I believe we > can get rid of all of the except the ones in: > Bayes::is_scan_available > PerMsgStatus::learn > and of course the Conf.pm stuff. Well, the other problem with this, of course, is that this is great for us, but what about the people who use our modules directly? I, for instance, have code that calls M::SA->learn() directly. Should that work if the config says "use_bayes 0"? IMO, it's up to the modules to check, not my calling code. I think we'd also want to alert people if using sa-learn w/ "use_bayes 0" so that they know the learning won't be used by default, or for users who think bayes is enabled, but the admin disabled it ... Should "spamassassin -r" and "-k" still teach the Bayes system in this case, and how is it related to bayes_learn_during_report? etc ... There's a lot of touchy issues here IMO. > If this is agreeable, I can finish up this patch and commit. So far we're -1.9 and +2, fyi. I'm leaning more to a -1 now, actually. So make that -2 and +2 overall. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
