> I'll change the rest of the "if (const = var)" to the more readable "if
(var
> == const)".
If you aren't inheren'tly a C or C++ guy, be aware that there is a valid
reason for this ugly coding style. It is really easy to type = instead of
== in an expression, and in most compilers you won't get a warning out of
this, the code simply will be badly broken. This is if you have the
variable in the left. If you have the constant on the left, you will get a
syntax error out of that slip, as assigning a value to a constant is illegal
in C/C++.
Now, I'd be in favor of swapping the code around to be less ugly too, were
it my project. But you have to be aware you are opening the door for
subtile bugs by doing that. It may or may not be an appropriate thing to do
in a open source project with many contributors.
Loren
