On Wed, Aug 17, 2005 at 02:26:09PM -0700, David S. Miller wrote: > > - if (uart_handle_sysrq_char(&up->port, ch, regs)) > > + if (ch && uart_handle_sysrq_char(&up->port, ch, regs)) > > uart_handle_sysrq_char() does the "if (ch)" check, you don't > need to add it here, that's superfluous.
Problem is, uart_handle_sysrq_char() still resets port->sysrq when called with a 0 character. During my testing it always first got called with a 0 character value after I send a break. The actual command key I pressed always got ignored as a result (and just got displayed to the screen). Could this be a bug in uart_handle_sysrq_char()? The impact of a fix there would be much wider and thus scares me. I do not know why I always see at least one 0 character after sending a break. Could be a sunzilog thing, could be a sparc thing, could be happening with all uart chips. I just don't know how widespread this behaviour is. Thanks for the feedback, -- Martin - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
