On Thu, Sep 01, 2005 at 02:21:23PM -0700, David S. Miller wrote:
> From: Martin Habets <[EMAIL PROTECTED]>
> Date: Wed, 17 Aug 2005 21:53:45 +0100
> 
> > It seems to me that all the BRK_ABRT handling in sunzilog_receive_chars()
> > never gets executed, and could be cleaned up. Can anyone confirm/deny
> > this?
> 
> We run receive processing first, and OR in the BRK_ABRT bit
> to the "r1" variable from the control register.
> 
> Only later do we do status processing and actually clear
> the interrupt status in the control register.

On my SS20 the first interrupt received is CHAEXT, triggering the status
processing. Only after that comes an interrupt with CHAxIP|CHAEXT set.

> So the break handling code in sunzilog_receive_chars() very
> much should be getting used.

Not on my machine, but this could work different on other hardware. So best
keep it.

Thanks,
-- 
Martin
-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to