From: Mark Fortescue <[EMAIL PROTECTED]>
Date: Sun, 29 Jul 2007 03:17:39 +0100 (BST)

> The serial console code selection code needs to select the ports the 
> otherway around. The attached patch fixes the problem.
> 
> --- linux-test/arch/sparc/kernel/prom.c~      2007-07-28 21:02:31.000000000 
> +0100
> +++ linux-test/arch/sparc/kernel/prom.c       2007-07-29 02:38:54.000000000 
> +0100
> @@ -460,7 +460,7 @@
>               strcpy(of_console_path, dp->full_name);
>               if (!strcmp(type, "serial")) {
>                       strcat(of_console_path,
> -                            (skip ? ":b" : ":a"));
> +                            (skip ? ":a" : ":b"));
>               }
>               break;

I don't understand this fix :-)

We set skip to "1" only if *romvec->pv_stdout is PROMDEV_TTYB,
therefore should definitely use ":b" when it is non-zero, which
is what the code is doing.

Perhaps the logic drivers/serial/sunzilog.c or
drivers/serial/suncore.c is what is reversed instead.

-
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to