Hi Ahmed, I just finished going through your documentation. The model looks good - I like the structure and methods for the creator info - I think I'll borrow some of those designs to improve the Java based implementation.
A suggestion for the license model - the SPDX tech workgroup devised a model for licenses during the development of the 1.0 spec. I could not find the original model on our wiki (I think it got lost when we moved to a different wiki site), but the license model is the same as the 2.0 model found here: http://wiki.spdx.org/view/Technical_Team/Proposals/2012-02-01/Merged_Model_P roposal The advantage to using the existing license model is that the classes and terms would be familiar to the SPDX workgroup and it may be more compatible with other language libraries implementing SPDX. You don't need to follow the model exactly to produce valid results, and I would recommend extending the model to make it easier for developers to use the libraries (for example, adding additional classes in the class hierarchy to abstract common items). Here are some specific suggestions: - Create an abstract AnyLicensingInfo class to represent all of the licenses. It would not have a license ID property, but could have a full_name property. - Create an abstract SimpleLicensingInfo class (subclass of AnyLicenseInfo) with two concrete subclasses StandardLicense and ExtractedLicensingInfo. - I would not use the licenseId to represent the conjunctive or disjunctive license information since it is only defined for ExtractedLicensingInfo and StandardLicense Gary > -----Original Message----- > From: [email protected] [mailto:spdx-tech- > [email protected]] On Behalf Of ahi > Sent: Friday, June 27, 2014 2:29 PM > To: [email protected] > Cc: [email protected]; Nuno Brito; Philippe Ombredanne > Subject: Re: mid-term evaluation > > I have added some content to the wiki > https://github.com/ah450/sdpx-tools-python/wiki , will add more > tomorrow. > let me know if I am going in the right direction with the content of > the documentation. > I have updated the README with an example and added two example files > one for parsing a tag/value file and one for writing a tag/value file. > > I am currently working on the following tasks: > > Updating the wiki : continuing to write documentation for already > implemented featues, and documenting new features before working on > them. Implementing package, license and file model validations. Adding > extracted license rules for tag/value parser. > > -- > Best Regards, > Ahmed > _______________________________________________ > Spdx-tech mailing list > [email protected] > https://lists.spdx.org/mailman/listinfo/spdx-tech _______________________________________________ Spdx-tech mailing list [email protected] https://lists.spdx.org/mailman/listinfo/spdx-tech
