Asking 2nd time. Also, must update with known issues, and possibke future extensions etc.
Btw, since this is supposed to be a community project, you must invite interested party to test/comment at some point (to be honest, other students reached that stage much sooner), and if you cannot engage the interests of somebody else to take a look at your work, then you fail, and fail you will. I don't want to keep saying the same thing to as many as 5th time. ------------------------------ On Tue, Jul 29, 2014 12:13 PM BST Hin-Tak Leung wrote: >Ahmed, >it has been 24 days since your last update. (commit is *not* update, and error >margin >for "every 10 days or so" shouldn't be x2+ ). > >There was a discussion elsewhere about your commits around #110 - out of >that, only about 2 are mult-line, and 95+ % are even shorter than the >auto-generated >signed-off lines. That's quite unsatisfactory - you may have problems finding >your own way around your own work, why you did what you did, after 6 months. > >I had another look a few days ago, at around #165 - there are a few more >multi-line >messages, but still the proportions are disappointing. We are not expecting >commit messages >to the details of the linux kernels - >(e.g. https://www.kernel.org/pub/linux/kernel/v3.x/ChangeLog-3.15.7 ) - but >yours are certainly on the short and poor side, by far. I also see only missing >signed-off line, which probably suggest that yours weren't auto-generated - >well, it is a git configuration (see "man git-config" for making it automatic). > >Anyway, I have already suggested a few times, that you could experiment with >git rebase -i (the interactive option) to edit your messages, and >also git config core.editor to configuring your favourite editor for your >needs. >You should try to polish up and expand your commit messages a good deal >more than you currently are, before pushing. You could of course >checkout a 2nd time to a temporary "play" repo to experiment, before you get >comfortable doing such editing. > > > > > > _______________________________________________ Spdx-tech mailing list [email protected] https://lists.spdx.org/mailman/listinfo/spdx-tech
