On Sun, Aug 10, 2014 at 8:47 PM, Hin-Tak Leung <[email protected]> wrote:
> 1) what are > > the still missing pieces, and future directions? Out of the planned features nothing is missing, however there are still minor bugs to be fixed. For the future, I believe the direction should be adding SPDX-2.0 support. 2) what would a user or a developer > interested in contributing/enhancing/adapting needs to know, and not yet > obvious? How all the classes fit together, The wiki and documentation shed light but I think we need more. Maybe a class diagram as well. > 3) what are the known problems? > Known issues can be found at https://github.com/ah450/sdpx-tools-python/issues, of course further testing would probably reveal more issues. FWIW, out of the 173 commits as of just now, minus 1 from somebody else > for the initial set up, there were just over 30 commits with a messages > longer than the signed-off line. (one of them don't have a signed-off line > - not compulsory - > just that it suggests you either work on two computers, one of which > doesn't have > the auto-signed-off set up, or that you are inserting it by hand. > Inserting by hand is > not efficient, that's all). That's somewhat improvement - around commit > 120, there were about 14. One of the things that bothered me a lot > were the "refactor xyz" commits, for all the reasons why short commit > mesages are bad: > (1) the message is all too brief about what actually changed, (2) some > words should be said about "why" it is done, (3) and "how" - what is > moving from where > to where, (4) frequently, what the message says, is not what is actually > done - > there are additional changes mixed in, which is unrelated to > "refactoring". > I think (4) is the worst crime in general - when a commit description does > not match > what the code diff actually does. > I have fixed some of the earlier history using rebase and pushed the updates, I am still working on the rest. -- Best Regards, Ahmed
_______________________________________________ Spdx-tech mailing list [email protected] https://lists.spdx.org/mailman/listinfo/spdx-tech
