On Mon, 1 Jul 2002, Tim Woodall wrote:

> On Mon, 1 Jul 2002, Edouard Gomez wrote:
> 
> > 
> > Hello,
> > 
> > This  lkml post  talks  about a  bug  which makes  a  ppp queue  waits
> > forever,  this looks  like our  "ppp is  alive but  i get  no traffic"
> > bug.  So i  would  like  somebody investigate  this  because i  cannot
> > reproduce the bug myself.
> > 
> > The  better would be  to contact  the author  of the  post to  get his
> > patch. 
> > 
> > The post archive :
> > http://www.uwsg.indiana.edu/hypermail/linux/kernel/0206.3/0433.html
> > 
> > There was no answer to his post. 
> > 
> > Thanks. 
> > 
> I have tried this, (guessed what the change was from the description)
> and it has made absolutely no difference. I have emailed the author
> to ask for a patch but he hasn't replied (yet)
> 
> I didn't expect it to make a difference as I'm pretty sure it is in the 
> usb read where the hang is occuring.
> 
I have now received a description of the change which is slightly different
to the one I tried:

=============== Quote =================
I won't give you the .patch or .diff file as i don't have the original code
handy. however, it's quite easy to patch manually.
just find ppp_xmit_process() in src/linux/drivers/net/ppp_generic.c and
replace
----------------------------------------------------------------------------
---------------------------
        if (ppp->xmit_pending == 0 && skb_peek(&ppp->file.xq) == 0
            && ppp->dev != 0)
                netif_wake_queue(ppp->dev);
----------------------------------------------------------------------------
---------------------------
with
----------------------------------------------------------------------------
---------------------------
        if (ppp->dev != 0)
                netif_wake_queue(ppp->dev);
----------------------------------------------------------------------------
---------------------------
WBR,
Denis Yarkovoy
=============== End Quote ===============


I don't think this will make any difference either but I will give it a try.
(It won't be until near the end of this week though if someone else wants
to try first) (I had commented out the whole of the if statement in my test)

Regards,

Tim.
-- 
God said, "div D = rho, div B = 0, curl E = - @B/@t, curl H = J + @D/@t," 
and there was light.

     http://tjw.hn.org/      http://www.locofungus.btinternet.co.uk/



Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se d�sinscrire : mailto:[EMAIL PROTECTED]?subject=unsubscribe

        

Reply via email to